Skip to content

implement the target path prefix#392

Merged
steiler merged 4 commits intomainfrom
gnmitargetpathprefix
Feb 12, 2026
Merged

implement the target path prefix#392
steiler merged 4 commits intomainfrom
gnmitargetpathprefix

Conversation

@steiler
Copy link
Collaborator

@steiler steiler commented Jan 28, 2026

No description provided.

@steiler steiler linked an issue Jan 28, 2026 that may be closed by this pull request
@steiler steiler marked this pull request as draft January 28, 2026 15:37
Copy link
Contributor

@henderiw henderiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steiler steiler marked this pull request as ready for review February 3, 2026 13:03
@steiler
Copy link
Collaborator Author

steiler commented Feb 9, 2026

This is now blocked by the #379 PR since both required changing the sdc-protos but the change from deviation field to revertive field is done in the other PR.

@steiler steiler force-pushed the gnmitargetpathprefix branch from 2d0df40 to cb2b411 Compare February 9, 2026 08:51
@henderiw henderiw moved this to Backlog in SDC project Feb 9, 2026
@henderiw henderiw moved this from Backlog to In review in SDC project Feb 9, 2026
@severindellsperger
Copy link

Alright, LGTM now.

@steiler
Copy link
Collaborator Author

steiler commented Feb 12, 2026

Manually tested, just the expected non-revertive tests fail.
https://github.com/sdcio/integration-tests/actions/runs/21944587375/job/63378772174
going to merge

@steiler steiler merged commit 78361fa into main Feb 12, 2026
9 of 10 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in SDC project Feb 12, 2026
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/server/datastore.go 0.00% 26 Missing ⚠️
pkg/datastore/target/gnmi/gnmi.go 0.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement the target name for gnmi

3 participants