add lint action by severindellsperger · Pull Request #324 · sdcio/data-server

severindellsperger · 2025-08-26T15:05:50Z

I added the lint GitHub action similar to the config-server.
Please review the changes and merge them if they look good to you.

Close #323

hansthienpondt

LGTM

steiler · 2025-09-01T07:00:20Z

also here why not use the caching package?

severindellsperger · 2025-09-01T08:13:56Z

@steiler the setup-go action will try to enable caching.
From setup-go: The action will try to enable caching unless the cache input is explicitly set to false.
Do you see any reason why we want to deactivate it?

codecov · 2026-01-15T08:05:53Z

Codecov Report

❌ Patch coverage is 21.23288% with 115 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/datastore/transaction_rpc.go	0.00%	19 Missing ⚠️
pkg/server/datastore.go	0.00%	17 Missing ⚠️
pkg/server/server.go	0.00%	16 Missing ⚠️
pkg/datastore/deviations.go	0.00%	11 Missing ⚠️
pkg/datastore/datastore_rpc.go	0.00%	8 Missing ⚠️
pkg/datastore/types/transaction.go	0.00%	8 Missing ⚠️
pkg/datastore/target/netconf/sync.go	0.00%	4 Missing ⚠️
pkg/tree/root_entry.go	69.23%	3 Missing and 1 partial ⚠️
pkg/tree/types/validation_result.go	0.00%	4 Missing ⚠️
main.go	0.00%	3 Missing ⚠️
... and 15 more

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

steiler · 2026-01-15T08:29:47Z

client/cmd/root.go

 	defer cancel()
-	cc, err := grpc.DialContext(ctx, addr,
-		grpc.WithBlock(),
+	cc, err := grpc.DialContext(ctx, addr, //nolint:staticcheck


I have added nolint for this deprecated call for now. At the same time I've opened the issue #377 that is about changing this to the NewClient() call.

Alright, works for me.

steiler · 2026-01-15T08:30:44Z

pkg/server/schema.go

 	dialCtx, cancel := context.WithTimeout(ctx, schemaServerConnectRetry)
 	defer cancel()
-	cc, err := grpc.DialContext(dialCtx, s.config.SchemaServer.Address, opts...)
+	cc, err := grpc.DialContext(dialCtx, s.config.SchemaServer.Address, opts...) //nolint:staticcheck


same here, fix deprecated calls later!
#377

severindellsperger

I reviewed the changes. Most of it looks good. However, I would check again if the returned errors can be ignored. I prefer a check for the error, or at least a log message, if there was one.

severindellsperger · 2026-01-15T08:50:48Z

client/cmd/data_blameConfig.go

 			b, err := opts.Marshal(rsp.ConfigTree)
 			if err != nil {
-				fmt.Fprintf(os.Stdout, "%v", err)
+				_, _ = fmt.Fprintf(os.Stdout, "%v", err)


Since you're not using a simple printf, you may want to check the return error of the function at least.

severindellsperger · 2026-01-15T08:54:11Z

client/cmd/datastore_get.go

 	table.Options(tablewriter.WithAlignment(tw.Alignment{tw.AlignLeft}))
-	table.Bulk(toTableData(rsp))
-	table.Render()
+	_ = table.Bulk(toTableData(rsp))


Here again, maybe you want to check the returned error here.

severindellsperger · 2026-01-15T08:54:24Z

client/cmd/datastore_get.go

-	table.Bulk(toTableData(rsp))
-	table.Render()
+	_ = table.Bulk(toTableData(rsp))
+	_ = table.Render()


Same here (error check).

severindellsperger · 2026-01-15T08:54:51Z

client/cmd/datastore_list.go

 	table.Options(tablewriter.WithAlignment(tw.Alignment{tw.AlignLeft}))
-	table.Bulk(tableData)
-	table.Render()
+	_ = table.Bulk(tableData)


Error check

severindellsperger · 2026-01-15T08:54:57Z

client/cmd/datastore_list.go

-	table.Bulk(tableData)
-	table.Render()
+	_ = table.Bulk(tableData)
+	_ = table.Render()


Error check

severindellsperger · 2026-01-15T09:11:15Z

pkg/datastore/target/netconf/nc_test.go

 	})

-	xmlBuilder.AddValue(ctx, &sdcpb.Path{
+	_ = xmlBuilder.AddValue(ctx, &sdcpb.Path{


AddValue seems to be a pretty difficult function that can return different errors. You may process/log them here.

severindellsperger · 2026-01-15T09:12:34Z

pkg/datastore/target/noop/noop.go

-	log := logf.FromContext(ctx).WithName("Get")
-	ctx = logf.IntoContext(ctx, log)
+	// log := logf.FromContext(ctx).WithName("Get")
+	// ctx = logf.IntoContext(ctx, log)


Can those comments be removed?

severindellsperger · 2026-01-15T09:17:24Z

pkg/pool/virtual_pool_test.go


 	// Task 1: blocks until cancelled
-	vp.SubmitFunc(func(ctx context.Context, submit func(Task) error) error {
+	_ = vp.SubmitFunc(func(ctx context.Context, submit func(Task) error) error {


Consider checking/logging the returned error if there is any.

severindellsperger · 2026-01-15T09:17:28Z

pkg/pool/virtual_pool_test.go


 	// Task 2: should run even if cancelled (to decrement inflight)
-	vp.SubmitFunc(func(ctx context.Context, submit func(Task) error) error {
+	_ = vp.SubmitFunc(func(ctx context.Context, submit func(Task) error) error {


Consider checking/logging the returned error if there is any.

severindellsperger · 2026-01-15T09:21:36Z

pkg/tree/root_entry.go


 // stringToDisk just for debugging purpose
-func (r *RootEntry) stringToDisk(filename string) error {
+func (r *RootEntry) stringToDisk(filename string) error { // nolint:unused


Is there no way to solve this differently so we don't have to mention the unused lint check directive?

you can chnage it to an uppercase Function, but then it is a public function ... and this is really only used by me I guess in debugging to write the tree to a file to be able to inspect it ... because of the limitations that vars are only displayed to a certain length bla bla

add lint action

c98755d

severindellsperger requested review from hansthienpondt, henderiw, karimra and steiler as code owners August 26, 2025 15:05

add 'go-version-file' to lint pipeline and remove caching

3f77377

hansthienpondt approved these changes Aug 28, 2025

View reviewed changes

hansthienpondt added the safe to test label Aug 28, 2025

severindellsperger mentioned this pull request Sep 1, 2025

Optimize Lint Action sdcio/config-server#371

Merged

steiler added 2 commits January 14, 2026 10:51

Merge branch 'main' into add-lint-action

b4dcb2f

fix linter issues

deb7bf0

steiler requested a review from alexandernorth as a code owner January 14, 2026 13:17

Merge branch 'main' into add-lint-action

cfc7dc3

steiler reviewed Jan 15, 2026

View reviewed changes

severindellsperger commented Jan 15, 2026

View reviewed changes

steiler assigned severindellsperger Jan 19, 2026

henderiw moved this to Backlog in SDC project Jan 19, 2026

henderiw added this to SDC project Jan 19, 2026

Conversation

severindellsperger commented Aug 26, 2025

Uh oh!

hansthienpondt left a comment

Choose a reason for hiding this comment

Uh oh!

steiler commented Sep 1, 2025

Uh oh!

severindellsperger commented Sep 1, 2025

Uh oh!

codecov bot commented Jan 15, 2026

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

severindellsperger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants