Open
Conversation
steiler
requested review from
hansthienpondt,
henderiw and
karimra
as code owners
Contributor
|
This PR is a mix of multiple things, so lets split this in several components that we want to enhance and doc it. This is already providing tag types already. No need to duplicate things |
henderiw
requested changes
Apr 14, 2025
Contributor
henderiw
left a comment
henderiw
left a comment
There was a problem hiding this comment.
This PR is a mix of multiple things, so lets split this in several components that we want to enhance and doc it.
e,g, https://github.com/sdcio/config-server/blob/9036de117fc43feac4c403fe7f08b188a46ac92d/apis/inv/v1alpha1/schema_types.go#L27C1-L33C2
This is already providing tag types already. No need to duplicate things
Contributor
|
can this be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.