Open
Conversation
This commit introduces a new feature that allows you to change the display mode of the modal component. A 3-dots menu has been added to the modal header, providing the following options: - Default: The standard centered modal. - Drawer: A sidebar that slides in from the right. - Fullscreen: A mode that fills a specified container element. Your selected display mode is persisted in `localStorage`. The `ModalProvider` has been updated to accept a `containerRef` prop to support the fullscreen mode within a specific container.
The previous build process did not include the `modal.css` file in the published package, causing a runtime error in consuming projects. This commit updates the `build` script in `package.json` to copy the `modal.css` file to the `lib` directory after compilation. This ensures that the CSS file is included in the published package and can be resolved at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new feature that allows you to change the display mode of the modal component.
A 3-dots menu has been added to the modal header, providing the following options:
Your selected display mode is persisted in
localStorage.The
ModalProviderhas been updated to accept acontainerRefprop to support the fullscreen mode within a specific container.