Update quotesbot #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
reviewed
Jul 13, 2020
|
|
||
| # Crawl responsibly by identifying yourself (and your website) on the user-agent | ||
| #USER_AGENT = 'quotesbot (+http://www.yourdomain.com)' | ||
| # USER_AGENT = 'holidaygems (+http://www.yourdomain.com)' |
|
|
||
| # Configure maximum concurrent requests performed by Scrapy (default: 16) | ||
| #CONCURRENT_REQUESTS = 32 | ||
| # CONCURRENT_REQUESTS = 32 |
Member
There was a problem hiding this comment.
Although not PEP8, I believe the comment spacing in lines like this one is correct for its purpose, which is marking commented out code, as opposed to code comments. I think we need to think of this file as a template for users, and hence leave it like that.
Also, I’m guessing this may be the result of scrapy startproject or similar, in which case the file contents should match those generated by Scrapy.
mikespub
added a commit
to mikespub-archive/scrapytest
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the spider code to follow modern guidelines, and the auto-generated files with the current docs URLs.
After that, I just realized that there was an old PR changing the
extract()/extract_first()toget()/getall().Closes: #7