Added a Feature of Ignoring some number tokens #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 98.78% 99.15% +0.37%
==========================================
Files 86 86
Lines 328 356 +28
Branches 61 69 +8
==========================================
+ Hits 324 353 +29
+ Misses 1 0 -1
Partials 3 3
|
dhananjaypai08
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Ignore parameter right now is for only the parse function(can also implement for parse_number and parse_ordinal once reviewed)
Ignoring parameters present in the ignore list and not parsing it to a number and simply adding it as it is to the output string and then keep building further. Also have added few test cases in test_number_parsing for the same. Let me know what you think and can update the Readme once its approved.