Skip to content

make ship and weapon class display names SCP_string #7186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Goober5000 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make ship and weapon class display names SCP_string #7186

Goober5000 wants to merge 1 commit into from
+83 −49

Conversation

@Goober5000
Copy link
Contributor

@Goober5000 Goober5000 commented Jan 6, 2026

All other display names are SCP_string, so make these SCP_string as well to be consistent and to allow arbitrary-length display names.

Also fix a few infelicities with German translation and the script API.

@Goober5000 Goober5000 added enhancement A new feature or upgrade of an existing feature to add additional functionality. general modding A general feature or issue related to modding capabilities of FSO Waiting for Stable Marks a pull request that is to be merged after the next stable release, due to a release cycle Requested by Active Mod A feature request that has been requested by a mod that is actively in development. labels Jan 6, 2026
@Goober5000
make ship and weapon class display names SCP_string
b4d9c3e 
All other display names are `SCP_string`, so make these `SCP_string` as well to be consistent and to allow arbitrary-length display names.

Also fix a few infelicities with German translation and the script API.
@Goober5000 Goober5000 force-pushed the ship_class_display_name branch from d7bb260 to b4d9c3e Compare January 6, 2026 04:13
@wookieejedi wookieejedi modified the milestone: Release 25.0.1 Jan 12, 2026
wookieejedi
wookieejedi approved these changes Feb 11, 2026
View reviewed changes
Copy link
Member

@wookieejedi wookieejedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and works in my tests, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wookieejedi wookieejedi wookieejedi approved these changes

Assignees

No one assigned

Labels

enhancement A new feature or upgrade of an existing feature to add additional functionality. general modding A general feature or issue related to modding capabilities of FSO Requested by Active Mod A feature request that has been requested by a mod that is actively in development. Waiting for Stable Marks a pull request that is to be merged after the next stable release, due to a release cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Goober5000 @wookieejedi