-
Notifications
You must be signed in to change notification settings - Fork 178
Adds Props as a new object type #6836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MjnMixael
wants to merge
28
commits into
scp-fs2open:master
Choose a base branch
from
MjnMixael:add_prop_object_type
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,787
−153
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
a1d7a4f
First draft of prop object type
MjnMixael 6000231
Add prop editor dialog in FRED
MjnMixael 0ad1443
prop sexps
MjnMixael 4edc1f9
lua table prop support
MjnMixael 8923980
lab support
MjnMixael d26ba21
lua mission access to props
MjnMixael 2aa4aed
prop collision support
Baezon cb79f37
use std::optional so the object->instance id is always valid
MjnMixael 054dd65
allow props to block suns
MjnMixael d20e680
minor cleanup and remove arbitrary limit. Still limited to 500 objects.
MjnMixael d6c6eb9
Sort props by category
MjnMixael bfdeec4
cleanup
MjnMixael 29fd122
implement collision hooks
MjnMixael 6a5043e
parse prop flags and further ensure props are inited and closed corre…
MjnMixael cb0f650
Add Cyborg's multi suggestions
MjnMixael 27720c7
fix missing header
MjnMixael 204dc44
add props to empty slots if available
MjnMixael 721bccb
add multi signature
MjnMixael 2a78b9f
fix rebase issues and match collisions to the new multithread style
MjnMixael 408404d
appease Clang the Conquerer
MjnMixael 77eb9d0
save/parse mission prop classes by name
MjnMixael e870c72
Clean up comments and finish TODOs
MjnMixael 81b205d
fix string errors
MjnMixael 7a0a6ec
clang wants this to be static now
MjnMixael 263fd03
address feedback
MjnMixael daa0857
address feedback
MjnMixael 96a46e1
Use model num from prop info instead
MjnMixael b9962ba
merge prop and ship collision group sexps together
MjnMixael File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ enum class LabMode { | |
| Asteroid, | ||
| Ship, | ||
| Weapon, | ||
| Prop, | ||
| None | ||
| }; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're already doing a round 2 here:
Is it possible to consolidate this with the function above, as they basically do the same thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on where you want to draw the line. Right now, iirc, this matches the code structure that ships do. If I update this are you going to want me to update ships also?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this, I'd rather not for now. This whole file could use consolidation and cleanup. However, this Props PR does a ton of changes already. I'd rather keep the change here as additive and later on someone can consolidate get_weapon_table_text, get_ship_table_text, get_asteroid_table_text, and get_prop_table_text as much as makes sense.