feat: Bump localforage dependency to 1.5#143
feat: Bump localforage dependency to 1.5#143NeverwinterMoon wants to merge 1 commit intoscotttrinh:masterfrom
Conversation
There are a few things that make 1.5 more desirable over 1.4 - one being this one localForage/localForage#633. Then again, 1.5 has one breaking change: https://github.com/localForage/localForage/releases/tag/1.5.0 This affects only the projects that use npm packaging (browserify/webpack)
|
I've considered this same thing, actually. However, I feel like the Safari breaking change is enough to keep me from wanting to do this without bumping our major version number, which I would want to bundle up with some other breaking changes we've been considering. I'd be open to accepting this PR if we also incorporated https://github.com/localForage/localForage-compatibility-1-4 so to avoid the breaking change for now. What do you think? |
|
@scotttrinh This does make sense to me, sure. I will try to incorporate the compatibility code and come back with the adjusted PR. Can't give any estimations yet as it's a bit hectic at work now. |
|
Thanks, @NeverwinterMoon! Let me know if there is anything I can do to support you. |
|
Any plans to make this happen? |
|
@mcarriere Nothing currently in the works, but I'd be happy to help with anyone who wants to take a stab at a PR. I no longer use it for my daily work, so I'd hope it would be driven mostly from people who do use it. |
There are a few things that make 1.5 more desirable over 1.4 - one being this one
localForage/localForage#633. Then again, 1.5 has one breaking change: https://github.com/localForage/localForage/releases/tag/1.5.0
This affects only the projects that use npm packaging (browserify/webpack)