chore: SCOP-8320 Classic-OOH defaults#274
Merged
ohalushchak-exadel merged 6 commits intomainfrom Sep 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Seeing all defaults I suggest we rename default_corporate_emissions_per_panel_per_day into
default_corporate_emissions_kgco2e_per_panel_per_day to be more explicit
The default_panel_to_disposal_distance_km_per_sq_metre: 0.6 can be removed as we decided not to use it.
On default_energy_kwh_per_mechanical_rotation_per_sq_metre we should rename it to default_mechanical_rotation_power_draw_watts_per_sq_metre to be consistent with the value in Watt and formula (my bad, only flagging this now).
cc @pymble2073
bdavy-scope3
approved these changes
Sep 19, 2025
gravelg
approved these changes
Sep 25, 2025
rachitm022
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.