Ensure skipped doctest are visible#312
Conversation
when they are skipped due to `__doctest_skip__` or `__doctest_requires__`.
|
Thanks! Do we need a change log in https://github.com/scientific-python/pytest-doctestplus/blob/main/CHANGES.rst ? p.s. Huh, no change log bot in this repo? |
and use "___" instead of the more commonly used "_" to avoid any potential naming collisions. Tweak `test_requires_module_variable` to check that no output is returned too.
|
Thank you Lars! |
| ================== | ||
|
|
||
|
|
||
| - Ensure that tests skipped with `__doctest_skip__` and `__doctest_requires__` |
There was a problem hiding this comment.
Do we need double backticks if we are not rendering the doc in Sphinx? I will let Brigitta decide. Thanks, all!
| - Ensure that tests skipped with `__doctest_skip__` and `__doctest_requires__` | |
| - Ensure that tests skipped with ``__doctest_skip__`` and ``__doctest_requires__`` |
There was a problem hiding this comment.
we don't sphinx build anything here, so it should not matter.
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Thank you, this is great!
My only comment is that the printout looks a bit more ugly than for the other skips; but I don't really see how this was caused with this diff. So would vote to go ahead nevertheless and if we're bothered by it too much a follow-up can fix the print style.
SKIPPED [1] <doctest astropy.stats.circstats.vtest[0]>:1: could not import 'scipy': No module named 'scipy'
SKIPPED [1] <doctest astropy.stats.funcs.binned_binom_proportion[0]>:1: listed in `__doctest_skip__`
SKIPPED [1] <doctest astropy.stats.funcs.binom_conf_interval[0]>:1: could not import 'scipy': No module named 'scipy'
SKIPPED [1] <doctest astropy.stats.funcs.poisson_conf_interval[0]>:1: could not import 'scipy': No module named 'scipy'
SKIPPED [1] <doctest astropy.stats.info_theory.akaike_info_criterion_lsq[0]>:1: could not import 'scipy': No module named 'scipy'
SKIPPED [1] <doctest astropy.stats.info_theory.bayesian_info_criterion_lsq[0]>:1: could not import 'scipy': No module named 'scipy'
SKIPPED [1] <doctest astropy.stats.jackknife.jackknife_stats[0]>:1: could not import 'scipy': No module named 'scipy'
SKIPPED [1] astropy/stats/tests/test_circstats.py:36: requires scipy
SKIPPED [1] astropy/stats/tests/test_circstats.py:118: requires scipy
SKIPPED [1] astropy/stats/tests/test_funcs.py:143: requires scipy
SKIPPED [1] astropy/stats/tests/test_funcs.py:228: requires scipy
SKIPPED [1] astropy/stats/tests/test_funcs.py:290: requires scipy
SKIPPED [1] astropy/stats/tests/test_funcs.py:443: requires scipy
SKIPPED [1] astropy/stats/tests/test_funcs.py:477: requires scipy
| ================== | ||
|
|
||
|
|
||
| - Ensure that tests skipped with `__doctest_skip__` and `__doctest_requires__` |
There was a problem hiding this comment.
we don't sphinx build anything here, so it should not matter.
3 participants
when they are skipped due to
__doctest_skip__or__doctest_requires__.Closes #246.
cc @bsipocz