TST: Debug and fix new Windows + Python 3.14 failure#308
TST: Debug and fix new Windows + Python 3.14 failure#308pllim wants to merge 2 commits intoscientific-python:mainfrom
Conversation
|
So this would work around the whole problem by ignoring ResourceWarning for everything. Is this too hacky? If not, I can clean up the commits. Please let me know! |
setup.cfg
Outdated
| # For pytest-asyncio deprecations that is expected to be resolved upstream | ||
| # https://github.com/pytest-dev/pytest-asyncio/issues/924 | ||
| ignore:The configuration option "asyncio_default_fixture_loop_scope":pytest.PytestDeprecationWarning | ||
| # Windows + Python 3.14 + pytest-dev have ResourceWarning, see |
There was a problem hiding this comment.
I wonder if we can add conditionals for this ignore and do it only for windows (and maybe for new versions)? I recall that I added that hackery to the config files before, but will need to dig a little bit to find which package it was.
|
OK, so it was surprising easy to dig this up, but I have this hackery for astroquery to add a windows specific filterwarning. This may or may not work for a pytest plugin though, but also, if we are confident that this is only an issue in our test suite and not with the plugin itself than this PR should be good enough as is already. https://github.com/astropy/astroquery/blob/main/conftest.py#L66 |
and globally ignore ResourceWarning TST: Revert scientific-python#307
Co-authored-by: Brigitta Sipőcz <bsipocz@gmail.com>
pllim
force-pushed
the
fix-win-py314-pt2
branch
from
3852968 to
f75b7c2
Compare
|
Re: #308 (comment) Thanks, @bsipocz ! That is a really neat trick. But why is it not working here? Did I do it wrong? |
|
Hmm, weird. Maybe it's not picking up the conftest file? I recall there were reasons we put it at the top level in astroquery. |
|
Argh I accidentally deleted the branch instead of force pushing and messed up this PR. I will open another one (#310). |
2 participants
Works around #305 , reverts #307