-
Notifications
You must be signed in to change notification settings - Fork 10
[Snyk] Fix for 5 vulnerabilities #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-DJANGO-14157807 - https://snyk.io/vuln/SNYK-PYTHON-DJANGO-14157810 - https://snyk.io/vuln/SNYK-PYTHON-SQLPARSE-14157217 - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14192442 - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14192443
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This is an automated security fix PR from Snyk that addresses 5 vulnerabilities by upgrading three dependencies: Django (from 3.2.25 to 4.2.27), sqlparse (from 0.4.4 to 0.5.4), and urllib3 (from 2.0.7 to 2.6.0). The PR adds minimum version constraints for these packages to requirements/local.txt to ensure transitive dependencies meet security requirements.
Key changes:
- Adds
django>=4.2.27to fix Django vulnerabilities (SNYK-PYTHON-DJANGO-14157807, SNYK-PYTHON-DJANGO-14157810) - Adds
sqlparse>=0.5.4to fix sqlparse vulnerability (SNYK-PYTHON-SQLPARSE-14157217) - Adds
urllib3>=2.6.0to fix urllib3 vulnerabilities (SNYK-PYTHON-URLLIB3-14192442, SNYK-PYTHON-URLLIB3-14192443)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| django-silk==5.3.2 | ||
| django-silk==5.3.2 | ||
| django>=4.2.27 # not directly required, pinned by Snyk to avoid a vulnerability |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Django version pin conflicts with the existing django==5.2.7 in requirements/base.txt (line 19). Since local.txt includes -r base.txt, pip will encounter a conflict between the exact pin (5.2.7) and the minimum version constraint (>=4.2.27).
While the constraint allows 5.2.7, having conflicting declarations can cause confusion and unexpected behavior. Consider either:
- Removing this line if base.txt already pins Django at a secure version
- Upgrading the version in base.txt to match the security requirements
- Using a version range that doesn't conflict (e.g., django>=5.2.7)
| django>=4.2.27 # not directly required, pinned by Snyk to avoid a vulnerability |
| pytest-django==4.8.0 # https://github.com/pytest-dev/pytest-django | ||
| tornado>=6.3.3 # not directly required, pinned by Snyk to avoid a vulnerability | ||
|
|
||
| django-test-migrations==1.3.0 |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
django-test-migrations==1.3.0 is already declared on line 15 and line 41. This creates a duplicate dependency declaration in the same requirements file, which can cause confusion and potential issues during dependency resolution.
| django-test-migrations==1.3.0 |
Snyk has created this PR to fix 5 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
requirements/local.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 SQL Injection
🦉 Allocation of Resources Without Limits or Throttling