Add MappableBase<TSelf> interface to guarantee toMap, toJson, and copyWith across generated models#317
Open
okandemirofficial wants to merge 2 commits intoschultek:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a small, self-referential generic interface MappableBase<TSelf extends MappableBase>.
All generated model mixins now implement MappableBase, so generic services can rely on toMap(), toJson(), and copyWith without extra flags.
Why
I often write generic helpers/services that should work with any mappable type:
Having a shared capability interface lets the compiler enforce these features at call sites.
What changed
Added base mixin MappableBase
Updated the generator to emit:
If this approach doesn’t make sense or there’s a better way to achieve it, please feel free to let me know and disregard the PR.
I really appreciate your work — thanks in advance for taking the time to review this!