Skip to content

Conversation

@isasmendiagus
Copy link
Contributor

@isasmendiagus isasmendiagus commented Jan 5, 2026

Summary by CodeRabbit

  • Chores
    • Updated release to 1.43.1 and adjusted release notes/links for clarity.
    • Restored the deprecated --no-wfp-output command-line flag; it has no functional effect and now emits a deprecation warning when used.

✏️ Tip: You can customize this high-level summary in your review settings.

@isasmendiagus isasmendiagus requested a review from eeisegn January 5, 2026 11:20
@coderabbitai
Copy link

coderabbitai bot commented Jan 5, 2026

📝 Walkthrough

Walkthrough

This release increments package version to 1.43.1, restores the deprecated --no-wfp-output CLI flag (prints a deprecation warning to stderr when used), and updates CHANGELOG.md to document the release and fix minor formatting/link entries.

Changes

Cohort / File(s) Change Summary
Version & Changelog
CHANGELOG.md, src/scanoss/__init__.py
Bumped __version__ from 1.43.0 to 1.43.1; added a [1.43.1] release entry; adjusted formatting and release links for prior entries.
CLI Deprecation Flag
src/scanoss/cli.py
Reintroduced deprecated --no-wfp-output flag to the scan command parser; help text marks it deprecated; using it prints a deprecation warning to stderr.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • eeisegn
  • agustingroh
  • matiasdaloia

Poem

🐰 A little flag hops back today,
Whispering warnings, bowing to stay,
Numbers nudged, the changelog sings,
Backwards steps on careful wings,
Hooray for small, kind compatibility! 🎋

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately reflects the main change: deprecating the --no-wfp-output CLI flag for backwards compatibility, which is confirmed by the changes in cli.py, init.py, and CHANGELOG.md.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1061b24 and 45512fc.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • src/scanoss/__init__.py
  • src/scanoss/cli.py
🚧 Files skipped from review as they are similar to previous changes (3)
  • src/scanoss/init.py
  • src/scanoss/cli.py
  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

SCANOSS SCAN Completed 🚀

  • Detected components: 1
  • Undeclared components: 0
  • Declared components: 1
  • Detected files: 103
  • Detected files undeclared: 0
  • Detected files declared: 103
  • Licenses detected: 1
  • Licenses detected with copyleft: 0
  • Policies: ✅ 1 pass (1 total)

View more details on SCANOSS Action Summary

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Fix all issues with AI Agents 🤖
In @src/scanoss/cli.py:
- Around line 1477-1478: The warning string on the print_stderr call exceeds the
max line length; shorten or split the message so the line is <=120 chars. Locate
the if args.no_wfp_output block and update the print_stderr invocation (the
print_stderr call referencing args.no_wfp_output) by either using a shorter
message or breaking the literal across multiple concatenated/parenthesized
strings so the single physical line no longer exceeds the limit.
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f953395 and 1061b24.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • src/scanoss/__init__.py
  • src/scanoss/cli.py
🧰 Additional context used
🧬 Code graph analysis (1)
src/scanoss/cli.py (2)
src/scanoss/scanossbase.py (1)
  • print_stderr (45-49)
src/scanoss/spdxlite.py (1)
  • print_stderr (55-59)
🪛 GitHub Actions: Lint
src/scanoss/cli.py

[error] 1478-1478: lint failed: E501 line too long (121 > 120) in src/scanoss/cli.py:1478.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (4)
src/scanoss/__init__.py (1)

25-25: LGTM! Version bump aligns with the new release.

The version update to 1.43.1 is consistent with the changelog and PR objectives.

src/scanoss/cli.py (1)

189-192: LGTM! Deprecated flag properly documented.

The flag is correctly marked as deprecated in the help text, clearly indicating it has no effect and directing users to the alternative.

CHANGELOG.md (2)

11-13: LGTM! Changelog properly documents the release.

The new 1.43.1 release entry clearly describes the restoration of the deprecated flag for backwards compatibility.


774-775: LGTM! Version links correctly updated.

The comparison links are properly added for the new release.

@isasmendiagus isasmendiagus force-pushed the chore/SP-3884/deprecate-no-wfp-output branch from 1061b24 to 45512fc Compare January 5, 2026 11:56
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

SCANOSS SCAN Completed 🚀

  • Detected components: 1
  • Undeclared components: 0
  • Declared components: 1
  • Detected files: 103
  • Detected files undeclared: 0
  • Detected files declared: 103
  • Licenses detected: 1
  • Licenses detected with copyleft: 0
  • Policies: ✅ 1 pass (1 total)

View more details on SCANOSS Action Summary

@isasmendiagus isasmendiagus merged commit 17926b2 into main Jan 5, 2026
6 checks passed
@isasmendiagus isasmendiagus deleted the chore/SP-3884/deprecate-no-wfp-output branch January 5, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants