-
Notifications
You must be signed in to change notification settings - Fork 23
chore(cli): deprecate --no-wfp-output flag for backwards compatibility #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis release increments package version to 1.43.1, restores the deprecated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SCANOSS SCAN Completed 🚀
View more details on SCANOSS Action Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Fix all issues with AI Agents 🤖
In @src/scanoss/cli.py:
- Around line 1477-1478: The warning string on the print_stderr call exceeds the
max line length; shorten or split the message so the line is <=120 chars. Locate
the if args.no_wfp_output block and update the print_stderr invocation (the
print_stderr call referencing args.no_wfp_output) by either using a shorter
message or breaking the literal across multiple concatenated/parenthesized
strings so the single physical line no longer exceeds the limit.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
CHANGELOG.mdsrc/scanoss/__init__.pysrc/scanoss/cli.py
🧰 Additional context used
🧬 Code graph analysis (1)
src/scanoss/cli.py (2)
src/scanoss/scanossbase.py (1)
print_stderr(45-49)src/scanoss/spdxlite.py (1)
print_stderr(55-59)
🪛 GitHub Actions: Lint
src/scanoss/cli.py
[error] 1478-1478: lint failed: E501 line too long (121 > 120) in src/scanoss/cli.py:1478.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (4)
src/scanoss/__init__.py (1)
25-25: LGTM! Version bump aligns with the new release.The version update to 1.43.1 is consistent with the changelog and PR objectives.
src/scanoss/cli.py (1)
189-192: LGTM! Deprecated flag properly documented.The flag is correctly marked as deprecated in the help text, clearly indicating it has no effect and directing users to the alternative.
CHANGELOG.md (2)
11-13: LGTM! Changelog properly documents the release.The new 1.43.1 release entry clearly describes the restoration of the deprecated flag for backwards compatibility.
774-775: LGTM! Version links correctly updated.The comparison links are properly added for the new release.
1061b24 to
45512fc
Compare
SCANOSS SCAN Completed 🚀
View more details on SCANOSS Action Summary |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.