Skip to content

add 'validationSlot' to transaction builders#189

Open
dragospe wants to merge 1 commit intomasterfrom
peter/verification-slot
Open

add 'validationSlot' to transaction builders#189
dragospe wants to merge 1 commit intomasterfrom
peter/verification-slot

Conversation

@dragospe
Copy link
Collaborator

The previous version hard-coded the slot to 1 during ledger rules validation.

It still defaults to 1L in the TxBuilder so as not to break compatibility, but it should probably be updated.

@fernweh0 fernweh0 requested a review from nau January 16, 2026 20:35
@nau
Copy link
Member

nau commented Jan 19, 2026

I'm actually considering removing validation from transaction building.
It's a separate responsibility and it in no way dependant on transaction building or its context.
It's done in the end and it can easily be extracted and handled separately.
Well, it relies on dummy signatures, but those easy to reconstruct via ctx.expectedSigners.

And we already have the Emulator for transaction validation in case you need it.

@dragospe, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants