[Do Not Merge] Pad formatter output based on the previous line#206
Open
resolritter wants to merge 2 commits intosbdchd:masterfrom
resolritter:indent-output
Open
[Do Not Merge] Pad formatter output based on the previous line#206resolritter wants to merge 2 commits intosbdchd:masterfrom resolritter:indent-output
resolritter wants to merge 2 commits intosbdchd:masterfrom
resolritter:indent-output
Conversation
resolritter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #204, it's possible to employ a naive way of "deducing" the correct indentation based on the previous line. That being said, this is in the same category of other post-processing output functions that the user could be interested in doing. Maybe introducing the "post-callbacks" option is more flexible than this.
No tests yet as the thought above has been presented and that would change the code quite a bit.