Training #1
Open
Training #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2017 16:52
phoenixwizard
requested changes
Dec 12, 2017
home.html
Outdated
| </a> | ||
| </span> | ||
| <div class="divNavigation"> | ||
| <a class="btnNavigate" href="#divHome">Home</a> |
Collaborator
There was a problem hiding this comment.
Never use camel casing. Only use hyphenated classes.
home.html
Outdated
| </div> | ||
| </div> | ||
| <div class="main"> | ||
| <div class="main" id="divHome"> |
home.html
Outdated
| <br> | ||
| </div> | ||
| <div class="divWhoWeAre"> | ||
| <div class="divWhoWeAre" id="divWhoWeAre"> |
Collaborator
There was a problem hiding this comment.
ID should not be camel case.
style.scss
Outdated
| float: right; | ||
|
|
||
| .btnNavigate{ | ||
| color: #55606e; |
Collaborator
There was a problem hiding this comment.
Put colors in separate colors.scss file.
style.scss
Outdated
| .btnNavigate{ | ||
| color: #55606e; | ||
| padding: 0 10px; | ||
| height: 88px; |
Collaborator
There was a problem hiding this comment.
Use only rem as a unit.
phoenixwizard
requested changes
Dec 12, 2017
home.html
Outdated
| <div id="services" class="div-services"> | ||
| <h2 class="centre">Services</h2> | ||
| <ul class="servicesUl"> | ||
| <li> |
Collaborator
There was a problem hiding this comment.
Why is the li without class?
home.html
Outdated
| <input type="button" class="btnLearn" value="Learn more about us" /> | ||
| <input type="button" class="btn-learn" value="Learn more about us" /> | ||
| </div> | ||
| <br> |
_colors.scss
Outdated
| @@ -0,0 +1,8 @@ | |||
| $primary-color: #ffffff; | |||
_variable.scss
Outdated
| @@ -0,0 +1,2 @@ | |||
| $padding: 0.375rem; | |||
_variable.scss
Outdated
| @@ -0,0 +1,2 @@ | |||
| $padding: 0.375rem; | |||
| $font: 'Open Sans','HelveticaNeue','Helvetica Neue',Helvetica,Arial; No newline at end of file | |||
home.html
Outdated
| <div class=innerHeader> | ||
| <div class=inner-header> | ||
| <span class="logo"> | ||
| <a href="/"> |
home.html
Outdated
| <div class=inner-header> | ||
| <span class="logo"> | ||
| <a href="/"> | ||
| <img height="90" width="270" src="https://argildx.com/wp-content/uploads/2017/05/final-logo-wdspace-300x98.png" alt="Argil DX"> |
| <img height="90" width="270" src="https://argildx.com/wp-content/uploads/2017/05/final-logo-wdspace-300x98.png" alt="Argil DX"> | ||
| </a> | ||
| </span> | ||
| <div class="div-navigation"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation buttons added