Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
samsmithnz
previously approved these changes
Dec 3, 2024
Collaborator
samsmithnz
left a comment
samsmithnz
left a comment
There was a problem hiding this comment.
It looks good to me - especially from the parser side.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Parser correctly pulls the building to the gameData, but still need to figure out the remaining UI implementation. We also are likely going in a different direction where the building could create a 'Demand' for a Product
(Initially, that didn't seem valuable since in most scenarios you want to see what is 'available' to export at a glance. Putting some items in a 'Sink' could obscure that information and confuse. However, it's beneficial for the space elevator parts. Those final parts will almost always be going to a Sink. And making sure they have a 'Sink' demand will keep it from showing 'Trim' or 'Not in Demand' for Production)