Adding vibration and gyro functionality #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I quickly went through your commits and found it impressive. Although I haven't run the code or tested it, your project looks promising. I would gladly accept the PR once you finish off the functions you intend to implement. Thank you for the contributions to the repo. |
|
@NateSchoolfield Hello, is this gyro worked?I find my miband4 can not write in 00000002-0000-3512-2118-0009af100700 |
|
This is worked, I got the gyro data from my mi band 4, @NateSchoolfield thanks! |
|
@Skypow2012 were you able to make it work? mine is stuck in "Starting gyro..." - no output comes out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added vibration and gyro functionality.
Added BYTEPATTERNS class to constants.py to name, contain, and dynamically generate bytepatterns (e.g., b'\x01\x00') using named hex strings also stored in class (e.g. '0100')
Added support for queued writes to allow for multithreading (sending vibrations while reading gyro data, for example)
Changes assume python3 due to the use of string formatting.
This is an initial PR, I've not yet incorporated the new bytepattern usage into the existing functions for auth, etc. I have done this in my derivative project, but I wanted to give you the chance to review these changes in isolation before moving forward there to see if they fit with your design goals.