Implement a sign-many command for better performance #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCO Remediation Commit for Tomas Restrepo <tomas@winterdom.com> I, Tomas Restrepo <tomas@winterdom.com>, hereby add my Signed-off-by to this commit: 5f5a75e I, Tomas Restrepo <tomas@winterdom.com>, hereby add my Signed-off-by to this commit: 5cf40d2 Signed-off-by: Tomas Restrepo <tomas@winterdom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed potential way to add the functionality to (sign multiple files at a time)[https://github.com//issues/34] when using the local client tool instead of the separate server process.
May not be the best way to go about it, but seemed like the simpler option, as it's very similar to the existing
signcommand but without support forstdinfor input.If you're signing multiple packages of the same type using an HSM or Cloud-backed token, the performance gains are substantial compared to doing it one at a time.