Remove duplicate settings in setup.py #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting description, name etc. in `setup.py` and `setup.cfg`, we switch to only setting them in `setup.cfg`. While using `setup.py` for this is still supported, the standard a couple years back was using `setup.cfg` - and now we moved off to `pyproject.toml`. The reason for this change is, that automatic Python package building with `hatch` fails in our CI. Removing these settings makes it work.
notque
approved these changes
Dec 5, 2025
Contributor
notque
left a comment
notque
left a comment
There was a problem hiding this comment.
I've added the metadata for discovery on PyPI. Otherwise, straight forward and reasonable. I approve. I am on vacation, so I will hand it to you to communicate, and get the additional approval.
fwiesel
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting description, name etc. in
setup.pyandsetup.cfg, we switch to only setting them insetup.cfg. While usingsetup.pyfor this is still supported, the standard a couple years back was usingsetup.cfg- and now we moved off topyproject.toml.The reason for this change is, that automatic Python package building with
hatchfails in our CI. Removing these settings makes it work.