Updates to ParallelManager, Typedefs, and Serial limits#335
Open
Updates to ParallelManager, Typedefs, and Serial limits#335
Conversation
- Check for scratch space required at level 0 before executing loop
- Templates TeamPolicy from ParallelManager, returns TeamPolicy after
updating with .set_scratch....
- Adds typedefs for {host,device}_unmanaged_... views
Previously we used ..._scratch_... views for unmanaged views, but
now we explicitly specify that ..._scratch_... is in the scratch space
- Performs a team scratch size check on neighbor search, ensuring there
is sufficient level 0 memory available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to typedefs are not backwards compatible, so this will be merged as part of 1.7.0.
Previously we used
Kokkos::View<double**, layout_right, host_execution_space, Kokkos::MemoryTraits<Kokkos::Unmanaged> >for host_scratch* types. However, we can do better by replacinghost_execution_spacewithhost_execution_space:scratch_memory_spaceand having another host_unmanaged_* types that has the sameKokkos::MemoryTraits<Kokkos::Unmanaged>attribute that scratch and unmanaged spaces previously had.