Streaming ZIP: avoid hang during central directory write and reduce CPU #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Download of ZIP file containing 50000 files stalled while zipfile wrote the central directory; Chrome spinner kept spinning and Python hit 100% CPU.
Root cause: bytes are immutable; _buffer += b caused O(n^2) copying during many small writes at close time. No data was yielded until the end.
Changes
Reworked ZipflyStream to be queue-backed with chunked staging:
Updated ZipFly.generator() to stream concurrently:
Small import additions: threading, queue.
ZipflyStream.init now takes chunksize (internal use only).