add --extensions cli arg for python filter#355
add --extensions cli arg for python filter#355oliverlambson wants to merge 1 commit intosamuelcolvin:mainfrom
Conversation
PR Change SummaryImplemented the
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
|
|
||
| def build_filter( | ||
| filter_name: str, ignore_paths_str: Optional[str] | ||
| filter_name: str, ignore_paths_str: Optional[str], extensions_str: Optional[str] = None |
There was a problem hiding this comment.
added a default to reduce blast radius of change, but i think no default would be more in-line with the rest of the repo. lmk if you would prefer i remove it and add the arg to all calls to build_filter
oliverlambson
changed the title
|
@samuelcolvin any feedback? |
1 participant
This cli option is mentioned in filters.py, but not implemented. I would find it very useful to have as a CLI option rather than having to implement a custom filter just to add a couple of extensions to the python filter.