Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, browser-box just remove the containers using
repo/browser-box:latestimage.While when install the browser-box, we should detect the version and update it to the wrapper scripts.
I have added a variable
BROWSER_BOX_VERSIONfor the version of browser-box. When install browser-box, we can useBROWSER_BOX_VERSIONfor specifying special version of browser-box.Another bug fixed:
workaround for
user already exist:BROWSER_BOX_USERto the user name of the user id in browser-box and create a directory in/home(may be need change the user's home directory).