Remove google-collections dependency #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-collections is old and has been succeeded by google-guava. It was only used in unit tests cases for the convenience of constructing small maps. These can be mostly replaced with Collections.singletonMap. Having it as a compile dependency meant that this was propagated to dependent projects. Theoretically a dependent project could be relying on this transitive dependency and break when it is removed, so I think this should be a minor version bump.
mudgeST
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google-collections is old and has been succeeded by google-guava. It was only used in unit tests cases for the convenience of constructing small maps. These can be mostly replaced with Collections.singletonMap. Having it as a compile dependency meant that this was propagated to dependent projects.
Theoretically a dependent project could be relying on this transitive dependency and break when it is removed, so I think this should be a minor version bump.