fix highlighting enum values in if/when exprs as procs#87
fix highlighting enum values in if/when exprs as procs#87morganholly wants to merge 3 commits intosaem:mainfrom
Conversation
|
Thanks for the PR @morganholly, I'm not sure I necessarily understand the change. Could you explain it so I can compare it with my own understanding? |
|
so i noticed it within this code. all of the itInt, valString, callbackBool, etc were highlighted as proc calls, but they’re enums flag = FlagVariantRef(kind: fkShortAndLong,
shortName: shortName,
longName: longName,
datatype: when T is int64: itInt elif T is float64: itFloat elif T is string: itString elif T is bool: itBool elif T is FuzzyBool: itFuzzyBool,
... |
|
however i think it may block highlighting actual proc calls in an object construction |
|
i will see if i need to slightly tweak the regex probably to look for an if, when, elif, else, of, etc |
|
so i didn't work on the regex yet but it doesn't highlight |
|
so i did some work on the regex, i have something working correctly in regex101 but vscode doesn't seem to like it so i have to do a bit more to get a good regex for this |
|
ok i found a workaround for the issue and added the fixed regex in |
|
it will require fixing merge conflicts at some point so i may do that ahead of time |
pull in changes from other PRs
No description provided.