chore(ci): add PHP 8.5 to CI workflows#259
Merged
phil-davis merged 3 commits intosabre-io:masterfrom Dec 1, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
============================================
- Coverage 94.24% 94.19% -0.05%
Complexity 262 262
============================================
Files 15 15
Lines 886 879 -7
============================================
- Hits 835 828 -7
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
That works OK. I will leave this to merge after PHP 8.5 is officially released in Nov 2025. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.5 works, use it in CI.
Only run php-cs-fixer on the oldest supported PHP 7.4 (when run with PHP 8.* it now tries to apply PHP 8.* code changes, which we don't want just yet)