プラン設定機能追加 by SasakiTakatsugu · Pull Request #10 · saasus-platform/implementation-sample-api-go

SasakiTakatsugu · 2025-10-02T00:47:43Z

No description provided.

Copilot

Pull Request Overview

Adds plan management functionality to enable users to view and update tenant pricing plans. The implementation includes API endpoints for retrieving pricing plans, tax rates, and managing tenant plan configurations.

Added REST endpoints for pricing plan and tax rate retrieval
Implemented tenant-specific plan information retrieval and updates
Added proper authorization checks using existing billing access controls

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
main.go	Added four new route handlers for plan management endpoints
billing.go	Implemented core plan management functions with proper error handling and authorization

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-02T00:48:22Z

billing.go

+	if plansResp.JSON200 == nil {
+		var msg pricingapi.Error
+		if err := json.Unmarshal(plansResp.Body, &msg); err != nil {
+			c.Logger().Error("failed to get pricing plans: %v", err)


Missing format verb: should use Errorf instead of Error when including the error variable.

Suggested change

c.Logger().Error("failed to get pricing plans: %v", err)

c.Logger().Errorf("failed to get pricing plans: %v", err)

Copilot · 2025-10-02T00:48:22Z

billing.go

+	if taxRatesResp.JSON200 == nil {
+		var msg pricingapi.Error
+		if err := json.Unmarshal(taxRatesResp.Body, &msg); err != nil {
+			c.Logger().Error("failed to get tax rates: %v", err)


Missing format verb: should use Errorf instead of Error when including the error variable.

Suggested change

c.Logger().Error("failed to get tax rates: %v", err)

c.Logger().Errorf("failed to get tax rates: %v", err)

Copilot · 2025-10-02T00:48:23Z

billing.go

+			c.Logger().Error("failed to get pricing plans: %v", err)
+			return c.String(http.StatusInternalServerError, "internal server error")
+		}
+		c.Logger().Error("failed to get pricing plans: %v", msg)


Missing format verb: should use Errorf instead of Error when including the msg variable.

Suggested change

c.Logger().Error("failed to get pricing plans: %v", msg)

c.Logger().Errorf("failed to get pricing plans: %v", msg)

Copilot · 2025-10-02T00:48:23Z

billing.go

+			c.Logger().Error("failed to get tax rates: %v", err)
+			return c.String(http.StatusInternalServerError, "internal server error")
+		}
+		c.Logger().Error("failed to get tax rates: %v", msg)


Missing format verb: should use Errorf instead of Error when including the msg variable.

Suggested change

c.Logger().Error("failed to get tax rates: %v", msg)

c.Logger().Errorf("failed to get tax rates: %v", msg)

SasakiTakatsugu · 2025-10-02T00:53:07Z

同機能修正

フロント
saasus-platform/implementation-sample-front-react#19

バックエンド
saasus-platform/implementation-sample-api-csharp#3
saasus-platform/implementation-sample-api-php#7
saasus-platform/implementation-sample-api-javascript#7
saasus-platform/implementation-sample-api-python#26
#10

javaのみ未着手

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-23T03:26:33Z

billing.go

+		usingNextPlanFromInt := int(*usingNextPlanFrom)
+		updateTenantPlanParam.UsingNextPlanFrom = &usingNextPlanFromInt


Potential integer overflow when converting int64 to int. On 32-bit systems, this conversion could lose data if the value exceeds the int range. Consider adding validation or using int64 consistently throughout the API.

Suggested change

usingNextPlanFromInt := int(*usingNextPlanFrom)

updateTenantPlanParam.UsingNextPlanFrom = &usingNextPlanFromInt

// Avoid unsafe conversion: assign int64 pointer directly

updateTenantPlanParam.UsingNextPlanFrom = usingNextPlanFrom

Copilot · 2025-10-23T03:26:34Z

billing.go

+		c.Logger().Error("failed to get user info")
+		return c.String(http.StatusInternalServerError, "internal server error")
+	}
+
+	if len(userInfo.Tenants) == 0 {
+		c.Logger().Error("user does not belong to any tenant")


[nitpick] Inconsistent logging practices: these Error() calls don't follow the Errorf() pattern used elsewhere in the same file (lines 618, 625, 628, etc.). For consistency with the rest of the codebase and proper structured logging, these should also use Errorf() even without format arguments.

Suggested change

c.Logger().Error("failed to get user info")

return c.String(http.StatusInternalServerError, "internal server error")

}

if len(userInfo.Tenants) == 0 {

c.Logger().Error("user does not belong to any tenant")

c.Logger().Errorf("failed to get user info")

return c.String(http.StatusInternalServerError, "internal server error")

}

if len(userInfo.Tenants) == 0 {

c.Logger().Errorf("user does not belong to any tenant")

Copilot · 2025-10-23T03:26:34Z

billing.go

+	}
+
+	if len(userInfo.Tenants) == 0 {
+		c.Logger().Error("user does not belong to any tenant")


[nitpick] Inconsistent logging practices: these Error() calls don't follow the Errorf() pattern used elsewhere in the same file (lines 618, 625, 628, etc.). For consistency with the rest of the codebase and proper structured logging, these should also use Errorf() even without format arguments.

Suggested change

c.Logger().Error("user does not belong to any tenant")

c.Logger().Errorf("user does not belong to any tenant")

Copilot · 2025-10-23T03:26:34Z

billing.go

+func getTaxRates(c echo.Context) error {
+	userInfo, ok := c.Get(string(ctxlib.UserInfoKey)).(*authapi.UserInfo)
+	if !ok {
+		c.Logger().Error("failed to get user info")


[nitpick] Inconsistent logging practices: these Error() calls don't follow the Errorf() pattern used elsewhere in the same file (lines 618, 625, 628, etc.). For consistency with the rest of the codebase and proper structured logging, these should also use Errorf() even without format arguments.

Suggested change

c.Logger().Error("failed to get user info")

c.Logger().Errorf("failed to get user info")

Copilot · 2025-10-23T03:26:35Z

billing.go

+	}
+
+	if len(userInfo.Tenants) == 0 {
+		c.Logger().Error("user does not belong to any tenant")


[nitpick] Inconsistent logging practices: these Error() calls don't follow the Errorf() pattern used elsewhere in the same file (lines 618, 625, 628, etc.). For consistency with the rest of the codebase and proper structured logging, these should also use Errorf() even without format arguments.

Suggested change

c.Logger().Error("user does not belong to any tenant")

c.Logger().Errorf("user does not belong to any tenant")

Copilot · 2025-10-23T03:26:35Z

billing.go

+
+	userInfo, ok := c.Get(string(ctxlib.UserInfoKey)).(*authapi.UserInfo)
+	if !ok {
+		c.Logger().Error("failed to get user info")


[nitpick] Inconsistent logging practices: these Error() calls don't follow the Errorf() pattern used elsewhere in the same file (lines 618, 625, 628, etc.). For consistency with the rest of the codebase and proper structured logging, these should also use Errorf() even without format arguments.

Suggested change

c.Logger().Error("failed to get user info")

c.Logger().Errorf("failed to get user info")

Copilot · 2025-10-23T03:26:35Z

billing.go

+
+	userInfo, ok := c.Get(string(ctxlib.UserInfoKey)).(*authapi.UserInfo)
+	if !ok {
+		c.Logger().Error("failed to get user info")


[nitpick] Inconsistent logging practices: these Error() calls don't follow the Errorf() pattern used elsewhere in the same file (lines 618, 625, 628, etc.). For consistency with the rest of the codebase and proper structured logging, these should also use Errorf() even without format arguments.

Suggested change

c.Logger().Error("failed to get user info")

c.Logger().Errorf("failed to get user info")

add-plan-setting-page

6bba01e

SasakiTakatsugu requested review from KooriyamaHiroki, bigdragon0610, Copilot and silent-bayline October 2, 2025 00:47

SasakiTakatsugu self-assigned this Oct 2, 2025

Copilot AI reviewed Oct 2, 2025

View reviewed changes

use Errorf instead of Error for formatted log messages

5c0ddf8

SasakiTakatsugu mentioned this pull request Oct 7, 2025

プラン設定変更の実装ガイドを追加 Anti-Pattern-Inc/saasus-platform-document#233

Merged

1 task

KooriyamaHiroki requested a review from Copilot October 23, 2025 03:25

Copilot AI reviewed Oct 23, 2025

View reviewed changes

KooriyamaHiroki approved these changes Oct 23, 2025

View reviewed changes

KooriyamaHiroki merged commit c34d241 into main Oct 23, 2025

	c.Logger().Error("failed to get pricing plans: %v", err)
	c.Logger().Errorf("failed to get pricing plans: %v", err)

	c.Logger().Error("failed to get tax rates: %v", err)
	c.Logger().Errorf("failed to get tax rates: %v", err)

		usingNextPlanFromInt := int(*usingNextPlanFrom)
		updateTenantPlanParam.UsingNextPlanFrom = &usingNextPlanFromInt

	c.Logger().Error("user does not belong to any tenant")
	c.Logger().Errorf("user does not belong to any tenant")

	c.Logger().Error("failed to get user info")
	c.Logger().Errorf("failed to get user info")

Conversation

SasakiTakatsugu commented Oct 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

SasakiTakatsugu commented Oct 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments