Fix backward truefalse arguments in example.rb#4
Open
bjnord wants to merge 2 commits intosaasbook:masterfrom
bjnord:master
Open
Fix backward truefalse arguments in example.rb#4bjnord wants to merge 2 commits intosaasbook:masterfrom bjnord:master
bjnord wants to merge 2 commits intosaasbook:masterfrom
bjnord:master
Conversation
1. Replace time_limit (minutes) with duration (seconds), rather than maintaining two quantities (since the former can be derived from the latter). 2. Make duration available to the HTML5 template as a local variable (replace the fixed '30 minutes' in the template with this).
Contributor
Author
|
Sorry; I learned something today, which is that I should have made branches for these two commits, so they could have been two separate pull requests. :-) I didn't realize it would automatically add the second commit into this pull request. The second commit changes the code to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two
truefalseexamples inexample.rbhave the text and answer arguments backwards.This might also suggest the need for validation of the answer argument for
truefalsequestions (should only accept a boolean?); let me know if you would find that helpful and I'll create a patch with code and spec.