feat: bungee support & fixed migrations running without data set#241
feat: bungee support & fixed migrations running without data set#241SgtJalau wants to merge 4 commits intosVoxelDev:masterfrom
Conversation
… an error because migration credentials aren't set
build.gradle
Outdated
|
|
||
| api 'io.ebean:ebean:12.12.0' | ||
| api 'io.ebean:ebean-querybean:12.12.1' | ||
| compileOnly "net.md-5:bungeecord-api:1.17-R0.1-SNAPSHOT" |
There was a problem hiding this comment.
Can you please make this use the implementation keyword instead of the old compileOnly?
|
|
||
| import net.md_5.bungee.api.plugin.Plugin; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Please remove the unneeded comment. Source control will show the author and date.
build.gradle
Outdated
|
|
||
| api 'io.ebean:ebean:12.12.0' | ||
| api 'io.ebean:ebean-querybean:12.12.1' | ||
| compileOnly "net.md-5:bungeecord-api:1.17-R0.1-SNAPSHOT" |
There was a problem hiding this comment.
Also please use the mcVersion variable instead of hard coding the version in the dependency.
| @@ -0,0 +1,4 @@ | |||
| name: EbeanWrapper | |||
| version: 1.0 | |||
There was a problem hiding this comment.
The version should be handled by the semantic-release plugin in the update-version.sh script. But I can also add this later.
|
The commit messages must also be updated to match the semantic versioning pattern. |
|
Hey, sorry I will make the changes soon! |
SgtJalau
changed the title
Is it fine now or what naming pattern do you mean? Also fixed the other things apart from the update-version.sh change. |
|
The tests and build are failing. Once fixed I will merge the PR. |
13 refactored a few things, so that will have to be done at a different time
2 participants
No description provided.