support parameterized arn generation; support elasticmq arn#54
Open
hzshlomi wants to merge 2 commits intos12v:masterfrom
Open
support parameterized arn generation; support elasticmq arn#54hzshlomi wants to merge 2 commits intos12v:masterfrom
hzshlomi wants to merge 2 commits intos12v:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
=========================================
- Coverage 40.52% 38.6% -1.93%
=========================================
Files 22 22
Lines 422 443 +21
Branches 13 18 +5
=========================================
Hits 171 171
- Misses 251 272 +21
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a quick fix allowing java users of the AWS SDK to get up and running quickly with elasticmq SQS queues registered on the SNS topics.
What I did is basically to transform ARNs starting with "arn:aws:sqs:elasticmq".
Everything i did is configurable, see (env var, configuration file property name):
ELASTICMQ_PREFIX, elasticmq.prefix
ELASTICMQ_ENDPOINT, elasticmq.endpoint
ELASTICMQ_ACCESS, elasticmq.access
ELASTICMQ_SECRET, elasticmq.secret
and also:
SNS_REGION, sns.region
SNS_ACCOUNT, sns.account
to allow control of the generated topic ARNs.
Pls let me know what needs to be done to merge this,
thanks for your work :)
Shlomi