[Feature Request]: Command Output #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The double `await`s are necessary since the MultiCommand::execute() method is both async and is carrying a Thenable from the child command, which also needs to be unwrapped to mimick the return value correctly.
ryuta46
reviewed
Jul 3, 2022
Owner
ryuta46
left a comment
ryuta46
left a comment
There was a problem hiding this comment.
Added a comment about the order of execution of each command in a sequence.
| let lastOutput: Thenable<unknown> | undefined; | ||
| for (let command of this.sequence) { | ||
| await command.execute(); | ||
| lastOutput = command.execute(); |
Owner
There was a problem hiding this comment.
Does removing await affect the order of execution of the sequence ?
Does the later command execute after the prior command has finished and waited the interval in setting ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Feature Request in Issue #50