Skip to content

Security Remediation: SQLi & Broken Access Control in token search #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightvision-pr-creator wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Security Remediation: SQLi & Broken Access Control in token search #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/main/java/hawk/service/SearchService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,11 @@ public List<Item> search(Search search) {
@Override
public List<Item> execute(Connection connection) throws SQLException {
List<Item> items = new ArrayList<>();
// The wrong way
String query = "select id, name, description from ITEM where description like '%" +
search.getSearchText() + "%'";

LOGGER.log(Level.INFO, "SQL Query: {0}", query);;
ResultSet rs = connection
.createStatement()
.executeQuery(query);

/* The righter way, should probably use built in Data Model for this, but this is safe
String query = "select id, name, description from ITEM where description like ?";
PreparedStatement statement = connection.prepareStatement(query);
statement.setString(1, "%" + search.getSearchText() + "%");
LOGGER.log(Level.INFO, "SQL Query {0}", statement);
ResultSet rs = statement.executeQuery();
*/

while (rs.next()) {
items.add(new Item(rs.getLong("id"), rs.getString("name"), rs.getString("description")));
Expand Down
Loading