expose the sni, if any. #2943
Merged
expose the sni, if any. #2943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcldan
force-pushed
the
sni
branch
7 times, most recently
from
90935db to
7abff6e
Compare
hcldan
commented
May 23, 2025
| @@ -0,0 +1,8 @@ | |||
| root = true | |||
Contributor
Author
There was a problem hiding this comment.
Not strictly related to the change, but I ran into some annoying check_style issues and it wasn't immediately clear how to properly run the checks on my machine.
This should help with general file formatting, trailing whitespace, and line endings at the end of files for those who use an editorconfig editor plugin. I highly recommend it!
Contributor
Author
|
@the10thWiz Could you please review this? |
Contributor
Author
|
@SergioBenitez would you like any other changes in order to get this into master? |
martynp
pushed a commit
to rocket-rs-community/Rocket
that referenced
this pull request
Dec 29, 2025
Grabs the SNI from TLS connections and saves to ConenctionMeta struct. Provides useful methods for exracting the SNI from requests.
martynp
pushed a commit
to rocket-rs-community/Rocket
that referenced
this pull request
Dec 30, 2025
Grabs the SNI from TLS connections and saves to ConenctionMeta struct. Provides useful methods for exracting the SNI from requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2942