Upgrade (almost) all dependencies #1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeb Rosen <jeb@jebrosen.com>
Also remove the use of the 'nightly' feature.
The latest version of 'mongodb' is async and implements its own internal connection pooling.
jebrosen
commented
Jul 21, 2020
| }; | ||
| } | ||
|
|
||
| table_and_asciiset! { |
Collaborator
Author
There was a problem hiding this comment.
I'm not super happy with this macro invocation (and table_to_ascii_set above). Most of the awkwardness is that AsciiSet's public API only has .add(u8), .remove(u8) and there is no public constructor for an "empty" AsciiSet. The other awkwardness is that you can't call add or remove with any u8 value above 127 apparently due to AsciiSet's bitpacking optimizations.
Some alternatives I thought of:
- The
const_if_matchfeature as originally proposed in Upgradepercent-encodingto 2.x andbase64to 0.12. #1349, which is stabilized but in onestablerelease later than we want for 0.5. - Have introspection APIs added to
AsciiSet, which could makePATH_CHARSunnecessary sinceAsciiSetcould be queried equivalently.AsciiSet's packed representation might lose some performance difference compared to thePATH_CHARSarray, however, and we would need to keep a macro like this one anyway.
Member
|
This is absolutely fantastic! Very clever, if unfortunately necessary, macro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a modified version of #1349.
Fixes #1341.
CC #1189.
This PR upgrades all direct dependencies except
tomlandpear(see #1353). It reduces the overall number of packages inCargo.lockfrom 466 to 390 by my count.rusted_cypher. It has a few old dependencies including hyper 0.10 and appears to be unmaintained for a few years now.mongodb. The latest version ofmongodbhasasync/awaitsupport and its own connection pooling, making it doubly unsuitable for the current implementation of#[database].