tree_to_callback: don't check document nodes for void elements #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walk_tree() will call this with PHG_ELEMENT_END for both document and element nodes, but only the latter ones have tag types defined. This fixes test failures seen on 32-bit big endian systems such as mips and powerpc, when a document node happened to have a valid (void) tag code at the same offset, triggering an early return. Bug-Debian: https://bugs.debian.org/904914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
walk_tree() will call this with PHG_ELEMENT_END for both document
and element nodes, but only the latter ones have tag types defined.
This fixes test failures seen on 32-bit big endian systems
such as mips and powerpc, when a document node happened
to have a valid (void) tag code at the same offset, triggering
an early return.
Bug-Debian: https://bugs.debian.org/904914