Backport lifetime change and bump version for release #436
Conversation
|
Looks like CI is sad for unrelated reasons. |
|
The release branch has accumulated some bitrot. Should be possible to fix by backporting a few more recent commits. (Does Claude know how to look at CI results and find the right commits to fix them?) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel-0.103 #436 +/- ##
============================================
Coverage ? 97.30%
============================================
Files ? 19
Lines ? 3783
Branches ? 0
============================================
Hits ? 3681
Misses ? 102
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Will look later today -- and send a separate PR. |
Return &'a str instead of &str to explicitly tie the lifetime of the returned string references to the 'a lifetime of the Cert struct, since the strings are derived from the certificate data.
alex
force-pushed
the
backport-lifetime
branch
from
aa6fa20 to
993137d
Compare
|
Thanks @djc ! |
|
Out of curiosity, what do you need this for? |
|
We've got our own verifier for URI SANs (internal PKI stuff), and there's a function that returns valid URIs, which right now is allocating |
3 participants
No description provided.