Tie lifetime of valid_dns_names/valid_uri_names to struct lifetime

[alex]

Return &'a str instead of &str to explicitly tie the lifetime of the returned string references to the 'a lifetime of the Cert struct, since the strings are derived from the certificate data.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.78%. Comparing base (b712306) to head (9586313).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files          19       19           
  Lines        3797     3797           
=======================================
  Hits         3675     3675           
  Misses        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[djc]

Thanks!

Note that the main branch is currently targeting 0.104. If you want this sooner, suggest backporting to the 0.103 release branch.

[alex]

Knowing that in OSS the answer is always "depends what people feel like doing", what do you think the difference in timeline for a release is between those?

I'm happy to do a backport, but if you're already planning to do a 0.104 in the next short while, I won't bother.

[djc]

0.104.0 will likely take between 2 and 4 months -- 0.103.x we can do today/tomorrow.

[alex]

Backport it is! Thanks