Conversation
The `CertificateRevocationList` trait is part of our public API and so the `verify_signature` fn within it can't have new arguments introduced in a semver compatible way in this 0.101.x release stream. We broke this contract when we added the `Budget` argument. This commit removes the `Budget` argument and updates `verify_cert` to consume signature budget before calling `verify_signature`. This maintains semver and we can implement better long term solutions in the next release.
cpu
commented
Sep 21, 2023
djc
approved these changes
Sep 21, 2023
Member
Author
|
Member
Author
|
I've also yanked 0.101.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch targets the
rel-0.101release branch to make a point release fixing #185.Proposed Release Notes
CertificateRevocationListtrait'sverify_signatureBudgetargument was removed. This was a semver incompatible change mistakenly introduced in v0.101.5.