fix win7 crash due to CERT_CHAIN_ENGINE_CONFIG #213
Merged
+35
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complexspaces
requested changes
Jan 15, 2026
Collaborator
complexspaces
left a comment
complexspaces
left a comment
There was a problem hiding this comment.
If this is greenlit for merging in the issue discussion, I think we should also remove the hypothetical wording from the backwards compatibility comments since @cstkingkey seems to be testing it on Windows 7 and confirming the re-definitions work.
cstkingkey
force-pushed
the
win7_support
branch
from
5baeff3 to
504f321
Compare
Author
|
@complexspaces patch is updated according your comments. |
djc
approved these changes
Jan 16, 2026
complexspaces
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212