[DNM] Fix windows for PR #29 #35
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a struct which keeps track of the file and offset associated with a guest memory region backed by a memory mapped file. Signed-off-by: Alexandru Agache <aagch@amazon.com>
Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com> Signed-off-by: Alexandru Agache <aagch@amazon.com>
Also, refactored some names and the way we resolve paths to use different `Error` and `Result` definitions. Signed-off-by: Alexandru Agache <aagch@amazon.com>
The GuestRegionMmap constructor now checks that adding the guest base address to the length of the mapped region does not overflow. Signed-off-by: Alexandru Agache <aagch@amazon.com>
The new method simplifies the creation of a GuestMemoryMmap object that contains file backed regions (potentially alongside anonymous memory regions). Also, updated the GuestMemoryRegion trait with the `file_offset` method, and implemented it for GuestRegionMmap. Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com> Signed-off-by: Alexandru Agache <aagch@amazon.com>
Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Author
|
@alexandruag this PR is not intended to be merged, but more a reference based on your PR #29, which I rebased on top of One thing to notice, I followed this document to be able build the code and the tests for windows, this was very handy. |
Member
|
Should we close this PR now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.