Skip to content

Update RELEASES.md for 1.54.0 #86696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 11 commits into from
Jul 26, 2021
Merged

Update RELEASES.md for 1.54.0 #86696

bors merged 11 commits into from
Jul 26, 2021

Conversation

@XAMPPRocky
Copy link
Contributor

@XAMPPRocky XAMPPRocky commented Jun 28, 2021

Rendered

r? @Mark-Simulacrum
cc @rust-lang/release

@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jun 28, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2021
XAMPPRocky
XAMPPRocky commented Jun 28, 2021
View reviewed changes
XAMPPRocky
XAMPPRocky commented Jun 28, 2021
View reviewed changes
jeffparsons
jeffparsons reviewed Jun 28, 2021
View reviewed changes
ehuss
ehuss reviewed Jun 28, 2021
View reviewed changes
jyn514
jyn514 reviewed Jun 29, 2021
View reviewed changes
mibac138
mibac138 reviewed Jun 29, 2021
View reviewed changes
XAMPPRocky and others added 4 commits June 29, 2021 13:26
@XAMPPRocky @mibac138
Update RELEASES.md
6d4161b 
Co-authored-by: Michael <5672750+mibac138@users.noreply.github.com>
@XAMPPRocky @jyn514
Update RELEASES.md
283080e 
Co-authored-by: Joshua Nelson <jyn514@gmail.com>
@XAMPPRocky @jeffparsons
Update RELEASES.md
2c489be 
Co-authored-by: Jeff Parsons <jeff@parsons.io>
@XAMPPRocky
Update RELEASES.md
3b16b6e
@cuviper
Copy link
Member

cuviper commented Jul 2, 2021

#85574 is a breaking change for soundness, which is likely to stay unless crater reveals widespread breakage. We should add a compatibility note for it.

Mark-Simulacrum
Mark-Simulacrum reviewed Jul 3, 2021
View reviewed changes
tschuett
tschuett reviewed Jul 5, 2021
View reviewed changes
@CryZe
Copy link
Contributor

CryZe commented Jul 7, 2021

Unless something changed in the meantime, 1.54 also enables mutable noalias for LLVM >= 12.

@Amanieu Amanieu linked an issue Jul 7, 2021 that may be closed by this pull request
stdarch - compile-time errors on invalid arguments #85264
Closed
@Amanieu Amanieu mentioned this pull request Jul 14, 2021
Closed
Mark-Simulacrum
Mark-Simulacrum reviewed Jul 22, 2021
View reviewed changes
Mark-Simulacrum
Mark-Simulacrum reviewed Jul 22, 2021
View reviewed changes
cuviper
cuviper previously requested changes Jul 22, 2021
View reviewed changes
Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of these seem to belong to 1.55.0 instead.

XAMPPRocky and others added 3 commits July 23, 2021 13:06
@XAMPPRocky
Update RELEASES.md
af0b855
@XAMPPRocky @Mark-Simulacrum
Update RELEASES.md
6e59a9d 
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
@XAMPPRocky
Update RELEASES.md
09b5ce3
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jul 23, 2021

@XAMPPRocky It looks like there are several comments outstanding here (one compat note, one note I just added, at least) and a few more relnotes marked issues:

@pietroalbini
Copy link
Member

pietroalbini commented Jul 26, 2021

We should also note #86063 in the compat notes.

@pietroalbini
Copy link
Member

pietroalbini commented Jul 26, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 26, 2021

📌 Commit 9fc2bfa has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2021
@pietroalbini pietroalbini mentioned this pull request Jul 26, 2021
Merged
@pietroalbini
Copy link
Member

pietroalbini commented Jul 26, 2021

@bors rollup

@bors
Copy link
Collaborator

bors commented Jul 26, 2021

⌛ Testing commit 9fc2bfa with merge fc24bce...

@bors
Copy link
Collaborator

bors commented Jul 26, 2021

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing fc24bce to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 26, 2021
@bors bors merged commit fc24bce into master Jul 26, 2021
@bors bors deleted the relnotes-1.54.0 branch July 26, 2021 14:42
@rustbot rustbot added this to the 1.56.0 milestone Jul 26, 2021
@pietroalbini pietroalbini added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jul 27, 2021
@pietroalbini pietroalbini mentioned this pull request Jul 27, 2021
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 27, 2021
@jyn514
Copy link
Member

jyn514 commented Aug 25, 2021

@CryZe do you happen to have a link to the PR that reenabled it? I've been having trouble finding it.

@jyn514
Copy link
Member

jyn514 commented Aug 25, 2021

Oh, I see - it was enabled in #82834 and disabled in 1.53 by #86036, but it was never disabled on (then) nightly, so it still landed in 1.54.

Going to make a PR adding it to the release notes.

@jyn514 jyn514 mentioned this pull request Aug 25, 2021
Merged
@fmease fmease mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehuss ehuss ehuss left review comments

@Amanieu Amanieu Amanieu left review comments

@tmandry tmandry tmandry left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

@scottmcm scottmcm scottmcm left review comments

@jackh726 jackh726 jackh726 left review comments

@cuviper cuviper cuviper left review comments

+4 more reviewers

@jeffparsons jeffparsons jeffparsons left review comments

@mibac138 mibac138 mibac138 left review comments

@tschuett tschuett tschuett left review comments

@jyn514 jyn514 jyn514 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. C-enhancement Category: An issue proposing an enhancement or a PR with one. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

stdarch - compile-time errors on invalid arguments