-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
compiler: Require mir_opt_level > 1 for SingleUseConsts MIR pass
#151426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Enselic
wants to merge
1
commit into
rust-lang:main
Choose a base branch
from
Enselic:single-use-consts-mir-opt-level
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
3c16dbc to
2be3ec0
Compare
2be3ec0 to
6b292c7
Compare
mir-opt-level > 1 for SingleUseConsts
mir-opt-level > 1 for SingleUseConstsSingleUseConsts
This comment has been minimized.
This comment has been minimized.
To make `tests/debuginfo/basic-stepping.rs` pass.
Note that we must keep `SingleUseConsts` enabled for
`tests/ui-fulldeps/rustc_public/check_allocation.rs` since its
`fn collect_consts()` assumes that:
VarDebugInfo {
name: "_false",
[...]
value: Place(
_5,
),
}
is transformed into which is what `SingleUseConsts` does:
VarDebugInfo {
name: "_false",
[...]
value: Const(
[...]
),
}
6b292c7 to
d7fffab
Compare
SingleUseConstsmir_opt_level > 1 for SingleUseConsts MIR pass
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
Member
Author
|
I have an idea for a better fix to check_allocation.rs. @rustbot author |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make
tests/debuginfo/basic-stepping.rspass.Note that we must keep
SingleUseConstsenabled fortests/ui-fulldeps/rustc_public/check_allocation.rssince itsfn collect_consts()assumes that:is transformed into the following which is what
SingleUseConstsdoes:Closes: #33013
CC author @celinval and reviewer @ouz-a of 0a0e7e6 as they may help determine if the fix to tests/ui-fulldeps/rustc_public/check_allocation.rs is acceptable or if some other change is needed.