-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Ship LLVM (rust-dev) in fast try builds again
#151196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Can you please leave an elaborating comment for why not to skip here? r=me after.
|
r? me |
c38d66e to
d079c3b
Compare
d079c3b to
41daada
Compare
|
@bors r=jieyouxu |
#142963 stopped shipping
rust-devin fast try builds, which was not actually correct, because if a PR modifies the LLVM submodule, we should provide the prebuilt LLVM for rustc-perf even in a (fast) try build. So why didn't we find out about this earlier? Well, because soon before that PR landed, we started using new bors for try builds, which actually broke bootstrap's git change detection logic, because new bors used a different e-mail address for merge commits.So the two bugs kind of masked each other out. Recently, we fixed the e-mail address and git change detection with new bors, since it's now also used for auto builds, but that in turn broke fast try builds that modify LLVM (#150722 (comment)), because rustc-perf saw that LLVM was modified in the try build, and it (correctly!) tried to download
rust-devfor the given try build commit, but that was (incorrectly!) missing on CI, due to being skipped.This PR restored building the
rust-devcomponent in fast try builds. In theory, we could use the same git detection logic that bootstrap uses and only do this if LLVM is actually modified in the given commit, but I'd rather do the correct thing here, than introduce additional opportunities for the git detection to desync.