Clean up rustc_attr_parsing

[GuillaumeGomez]

Follow-up of #150934.

It removes the Option<> wrapping for SharedContext::target field and completely removed the target_id field. Considering this type contains a closure and never updates its target_id field, there is no need to keep it around, it can be used directly in the lint emitter.

r? @JonathanBrouwer

[rustbot]

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

[GuillaumeGomez]

I don't expect any perf change but just in case:

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: fb50715 (fb507154de75738e8d91f27a9e5fad530a7354dc, parent: a6acf0f07f0ed1c12e26dc0db3b9bf1d0504a0bb)

[rust-timer]

Finished benchmarking commit (fb50715): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.2%]	4
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.873s -> 473.523s (-0.07%)
Artifact size: 383.59 MiB -> 383.57 MiB (-0.01%)

[JonathanBrouwer]

@bors r+ rollup=never
Rollup=never for perf

[rust-bors]

📌 Commit 8205792 has been approved by JonathanBrouwer

It is now in the queue for this repository.