-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Support slices in type reflection #151118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
This comment has been minimized.
This comment has been minimized.
|
Needs a rebase. Otherwise lgtm |
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
☔ The latest upstream changes (presumably #151381) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors delegate+ r=me after rebase |
Tracking issue: #146922
This PR adds support for inspecting slices
[T]through type reflection. It does so by adding the newSlicestruct + variant, which is very similar toArraybut without thelenfield:Here is an example reflecting a slice:
In addition to this, I also re-arranged the type info unit tests.
r? @oli-obk