-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
compiler: upgrade to hashbrown 0.16.1 #151076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
See also rust-lang#135634, rust-lang#149159, and rust-lang/hashbrown#662. This includes an in-tree upgrade of `indexmap` as well, which uses the new `HashTable` buckets API internally, hopefully impacting performance for the better!
|
|
@bors try |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
compiler: upgrade to hashbrown 0.16.1
| "fluent-langneg", | ||
| "fluent-syntax", | ||
| "fnv", | ||
| "foldhash", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a false positive due to hashbrown's nightly = ["foldhash?/nightly"], rust-lang/cargo#10801, but I can't add a comment here since this is an auto-generated/blessed source file. I did add a similar comment in PERMITTED_STDLIB_DEPENDENCIES in #149159.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (b09b198): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.6%, secondary -1.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.7%, secondary -3.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 476.337s -> 473.121s (-0.68%) |
|
Perf results look like a wash to me, which I guess is not bad news. I forgot that I'd published indexmap v2.13.0 since I started testing this though, so let's try with that too, if only to keep up with the latest. @bors try |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
compiler: upgrade to hashbrown 0.16.1
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (2e3ca0d): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.1%, secondary -2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 474.424s -> 473.528s (-0.19%) |
See also #135634, #149159, and rust-lang/hashbrown#662.
This includes an in-tree upgrade of
indexmapas well, which uses thenew
HashTablebuckets API internally, hopefully impacting performancefor the better.
And finally, we can remove
#[rustc_unsafe_specialization_marker]onCopy!cc @joboet
r? @Amanieu