Remove a workaround for a bug (take 2) #151002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think it is necessary anymore. As I understand it from issue 39504 the original problem was that rustbuild changed a hardlink in the cargo build dir to point to copy in the sysroot while cargo may have hardlinked it to the original first. I don't think this happens anymore and as such this workaround is no longer necessary.
rustbot
added
S-waiting-on-review
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
rust-bors
bot
added
the
S-waiting-on-bors
This comment was marked as outdated.
This comment was marked as outdated.
rust-bors
bot
removed
the
S-waiting-on-review
This comment was marked as outdated.
This comment was marked as outdated.
rust-bors
bot
added
S-waiting-on-author
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@bors try jobs=x86_64-gnu-distcheck |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
Remove a workaround for a bug (take 2) try-job: x86_64-gnu-distcheck
Contributor
Member
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Member
|
Great that CI now passes. r? me @bors r+ |
rust-bors
bot
added
the
S-waiting-on-bors
rust-bors
bot
removed
the
S-waiting-on-review
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 12, 2026
Remove a workaround for a bug (take 2) I don't think it is necessary anymore. As I understand it from issue 39504 the original problem was that rustbuild changed a hardlink in the cargo build dir to point to copy in the sysroot while cargo may have hardlinked it to the original first. I don't think this happens anymore and as such this workaround is no longer necessary I can't reproduce the CI failure in rust-lang#122186 locally with `./x.py test library/core`. It is possible this got fixed by rust-lang#149273.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
…uwer Rollup of 13 pull requests Successful merges: - #145343 (Dogfood `-Zno-embed-metadata` in the standard library) - #150151 (Destabilise `target-spec-json`) - #150723 (std: move `errno` and related functions into `sys::io`) - #150771 (Remove legacy homu `try` and `auto` branch mentions) - #150826 (Add `f16` inline ASM support for s390x) - #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`) - #150943 (Port `#[must_not_suspend]` to attribute parser) - #150990 (std: sys: net: uefi: Make TcpStream Send) - #150995 (core: ptr: split_at_mut: fix typo in safety doc) - #150998 (Relax test expectation for @__llvm_profile_runtime_user) - #151002 (Remove a workaround for a bug (take 2)) - #151005 (Fix typo in `MaybeUninit` docs) - #151011 (Update books) r? @ghost
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 12, 2026
Remove a workaround for a bug (take 2) I don't think it is necessary anymore. As I understand it from issue 39504 the original problem was that rustbuild changed a hardlink in the cargo build dir to point to copy in the sysroot while cargo may have hardlinked it to the original first. I don't think this happens anymore and as such this workaround is no longer necessary I can't reproduce the CI failure in rust-lang#122186 locally with `./x.py test library/core`. It is possible this got fixed by rust-lang#149273.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
Rollup of 12 pull requests Successful merges: - #145343 (Dogfood `-Zno-embed-metadata` in the standard library) - #150151 (Destabilise `target-spec-json`) - #150723 (std: move `errno` and related functions into `sys::io`) - #150826 (Add `f16` inline ASM support for s390x) - #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`) - #150943 (Port `#[must_not_suspend]` to attribute parser) - #150990 (std: sys: net: uefi: Make TcpStream Send) - #150995 (core: ptr: split_at_mut: fix typo in safety doc) - #150998 (Relax test expectation for @__llvm_profile_runtime_user) - #151002 (Remove a workaround for a bug (take 2)) - #151005 (Fix typo in `MaybeUninit` docs) - #151011 (Update books) r? @ghost
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
…uwer Rollup of 14 pull requests Successful merges: - #150151 (Destabilise `target-spec-json`) - #150826 (Add `f16` inline ASM support for s390x) - #150883 (Improve span for "unresolved intra doc link" on `deprecated` attribute) - #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`) - #150943 (Port `#[must_not_suspend]` to attribute parser) - #150990 (std: sys: net: uefi: Make TcpStream Send) - #150995 (core: ptr: split_at_mut: fix typo in safety doc) - #150998 (Relax test expectation for @__llvm_profile_runtime_user) - #151002 (Remove a workaround for a bug (take 2)) - #151005 (Fix typo in `MaybeUninit` docs) - #151011 (Update books) - #151029 (rustc-dev-guide subtree update) - #151032 (fix: added missing backtick in triagebot.toml) - #151035 (Don't suggest replacing closure parameter with type name) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 13, 2026
Rollup merge of #151002 - remove_bug_workaround, r=lqd Remove a workaround for a bug (take 2) I don't think it is necessary anymore. As I understand it from issue 39504 the original problem was that rustbuild changed a hardlink in the cargo build dir to point to copy in the sysroot while cargo may have hardlinked it to the original first. I don't think this happens anymore and as such this workaround is no longer necessary I can't reproduce the CI failure in #122186 locally with `./x.py test library/core`. It is possible this got fixed by #149273.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it is necessary anymore. As I understand it from issue 39504 the original problem was that rustbuild changed a hardlink in the cargo build dir to point to copy in the sysroot while cargo may have hardlinked it to the original first. I don't think this happens anymore and as such this workaround is no longer necessary
I can't reproduce the CI failure in #122186 locally with
./x.py test library/core. It is possible this got fixed by #149273.